Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate @fluentui/make-styles-webpack-loader #20757

Merged
merged 6 commits into from
Nov 25, 2021
Merged

chore: migrate @fluentui/make-styles-webpack-loader #20757

merged 6 commits into from
Nov 25, 2021
+44 −18

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Nov 24, 2021 •
edited
Loading

Pull request checklist

Description of changes

@layershifter layershifter requested a review from a team as a code owner November 24, 2021 13:41
@layershifter layershifter added the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@layershifter layershifter requested a review from a team November 24, 2021 13:41
@layershifter layershifter mentioned this pull request Nov 24, 2021
Closed
39 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 24, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dc4ae6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2021 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 8bb041d4bda9bff393cfe39bd9d1509cb6ee6a81

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 8a141d1

Possible causes

  • The baseline build 8a141d1 is broken
  • The Size Auditor run for the baseline build 8a141d1 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@layershifter layershifter removed the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1197 1152 5000
BaseButton mount 1242 1224 5000
Breadcrumb mount 3010 3037 1000
ButtonNext mount 732 735 5000
Checkbox mount 2007 1939 5000
CheckboxBase mount 1691 1684 5000
ChoiceGroup mount 5688 5592 5000
ComboBox mount 1281 1266 1000
CommandBar mount 11150 11260 1000
ContextualMenu mount 9379 9420 1000
DefaultButton mount 1448 1482 5000
DetailsRow mount 4417 4366 5000
DetailsRowFast mount 4468 4409 5000
DetailsRowNoStyles mount 4170 4206 5000
Dialog mount 2939 2848 1000
DocumentCardTitle mount 347 328 1000
Dropdown mount 3757 3789 5000
FluentProviderNext mount 4285 4288 5000
FluentProviderWithTheme mount 413 414 10
FluentProviderWithTheme virtual-rerender 279 328 10
FluentProviderWithTheme virtual-rerender-with-unmount 449 449 10
FocusTrapZone mount 2159 2193 5000
FocusZone mount 2184 2141 5000
IconButton mount 2239 2189 5000
Label mount 552 558 5000
Layer mount 3437 3532 5000
Link mount 733 729 5000
MakeStyles mount 2096 2113 50000
MenuButton mount 1895 1867 5000
MessageBar mount 2332 2364 5000
Nav mount 3810 3854 1000
OverflowSet mount 1391 1421 5000
Panel mount 2820 2847 1000
Persona mount 1111 1105 1000
Pivot mount 1735 1757 1000
PrimaryButton mount 1657 1614 5000
Rating mount 9052 9127 5000
SearchBox mount 1727 1718 5000
Shimmer mount 3048 3114 5000
Slider mount 2362 2366 5000
SpinButton mount 5708 5764 5000
Spinner mount 652 651 5000
SplitButton mount 3774 3696 5000
Stack mount 746 758 5000
StackWithIntrinsicChildren mount 2145 2162 5000
StackWithTextChildren mount 5515 5527 5000
SwatchColorPicker mount 11708 11752 5000
TagPicker mount 3143 3122 5000
TeachingBubble mount 14238 14319 5000
Text mount 648 687 5000
TextField mount 1724 1811 5000
ThemeProvider mount 1488 1484 5000
ThemeProvider virtual-rerender 795 845 5000
ThemeProvider virtual-rerender-with-unmount 2288 2277 5000
Toggle mount 1080 1076 5000
buttonNative mount 332 333 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 215 192 1.12:1
ButtonMinimalPerf.default 227 207 1.1:1
RadioGroupMinimalPerf.default 563 523 1.08:1
SegmentMinimalPerf.default 434 402 1.08:1
BoxMinimalPerf.default 435 406 1.07:1
FormMinimalPerf.default 520 485 1.07:1
SkeletonMinimalPerf.default 452 427 1.06:1
TextAreaMinimalPerf.default 615 582 1.06:1
CarouselMinimalPerf.default 565 536 1.05:1
ReactionMinimalPerf.default 462 442 1.05:1
TreeMinimalPerf.default 942 900 1.05:1
HeaderMinimalPerf.default 428 413 1.04:1
ListWith60ListItems.default 778 746 1.04:1
TableManyItemsPerf.default 2271 2182 1.04:1
AttachmentMinimalPerf.default 192 186 1.03:1
ChatMinimalPerf.default 789 765 1.03:1
ImageMinimalPerf.default 449 434 1.03:1
ListNestedPerf.default 667 648 1.03:1
IconMinimalPerf.default 757 732 1.03:1
AttachmentSlotsPerf.default 1230 1209 1.02:1
AvatarMinimalPerf.default 237 233 1.02:1
ButtonSlotsPerf.default 647 635 1.02:1
DatepickerMinimalPerf.default 6234 6140 1.02:1
ItemLayoutMinimalPerf.default 1410 1378 1.02:1
ListMinimalPerf.default 608 596 1.02:1
PopupMinimalPerf.default 664 648 1.02:1
SplitButtonMinimalPerf.default 4939 4824 1.02:1
TableMinimalPerf.default 474 464 1.02:1
ButtonOverridesMissPerf.default 1917 1889 1.01:1
ChatDuplicateMessagesPerf.default 345 341 1.01:1
CheckboxMinimalPerf.default 3026 2985 1.01:1
DropdownMinimalPerf.default 3313 3271 1.01:1
GridMinimalPerf.default 402 399 1.01:1
PortalMinimalPerf.default 190 189 1.01:1
ProviderMergeThemesPerf.default 1843 1831 1.01:1
RefMinimalPerf.default 255 252 1.01:1
StatusMinimalPerf.default 802 793 1.01:1
ToolbarMinimalPerf.default 1102 1093 1.01:1
CardMinimalPerf.default 678 677 1:1
DialogMinimalPerf.default 850 847 1:1
EmbedMinimalPerf.default 4638 4659 1:1
HeaderSlotsPerf.default 887 883 1:1
InputMinimalPerf.default 1462 1463 1:1
LabelMinimalPerf.default 453 453 1:1
MenuButtonMinimalPerf.default 1871 1880 1:1
RosterPerf.default 1385 1379 1:1
SliderMinimalPerf.default 1891 1893 1:1
CustomToolbarPrototype.default 4480 4495 1:1
DividerMinimalPerf.default 426 432 0.99:1
DropdownManyItemsPerf.default 799 804 0.99:1
ListCommonPerf.default 750 759 0.99:1
MenuMinimalPerf.default 997 1006 0.99:1
ProviderMinimalPerf.default 1277 1291 0.99:1
TooltipMinimalPerf.default 1194 1201 0.99:1
AlertMinimalPerf.default 323 330 0.98:1
ChatWithPopoverPerf.default 442 452 0.98:1
LayoutMinimalPerf.default 426 433 0.98:1
LoaderMinimalPerf.default 757 776 0.98:1
VideoMinimalPerf.default 729 747 0.98:1
TextMinimalPerf.default 411 425 0.97:1
FlexMinimalPerf.default 344 358 0.96:1
AnimationMinimalPerf.default 464 496 0.94:1
AccordionMinimalPerf.default 175 203 0.86:1

@layershifter layershifter merged commit f0083b8 into master Nov 25, 2021
@layershifter layershifter deleted the chore/migrate-mkwl branch November 25, 2021 08:56
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@layershifter
chore: migrate @fluentui/make-styles-webpack-loader (microsoft#20757)
5d92447 
* chore: migrate @fluentui/make-styles-webpack-loader

* Change files

* chore: migrate @fluentui/make-styles-webpack-loader

* applied suggestions from another PR

* restore jest config

* restore fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@layershifter @fabricteam @ling1726 @khmakoto